Page MenuHomePhabricator

Set an explicit height when drawing the dependent revision graph
ClosedPublic

Authored by epriestley on Oct 16 2020, 9:04 PM.
Tags
None
Referenced Files
F13101577: D21481.diff
Sat, Apr 27, 12:35 AM
Unknown Object (File)
Thu, Apr 25, 3:10 AM
Unknown Object (File)
Sat, Apr 20, 5:27 PM
Unknown Object (File)
Sun, Mar 31, 4:40 AM
Unknown Object (File)
Fri, Mar 29, 3:43 PM
Unknown Object (File)
Mar 12 2024, 4:57 PM
Unknown Object (File)
Mar 10 2024, 9:07 PM
Unknown Object (File)
Jan 31 2024, 4:35 PM
Subscribers
None

Details

Summary

See PHI1900. Recent changes to how commit graphs are drawn made the height automatic in most cases, but it fails in Differential because the element isn't initially visible so the computed height is 0.

Just give them an explicit height so they show up again.

Test Plan

Viewed graphs in Maniphest, Differential, and Diffusion; saw them all render properly.

Diff Detail

Repository
rP Phabricator
Branch
gheight1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24942
Build 34413: Run Core Tests
Build 34412: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 9:10 PM
This revision was automatically updated to reflect the committed changes.