Page MenuHomePhabricator

Set an explicit height when drawing the dependent revision graph
ClosedPublic

Authored by epriestley on Oct 16 2020, 9:04 PM.
Tags
None
Referenced Files
F14726735: D21481.diff
Sat, Jan 18, 3:44 AM
Unknown Object (File)
Dec 4 2024, 4:29 PM
Unknown Object (File)
Dec 3 2024, 2:02 AM
Unknown Object (File)
Nov 27 2024, 11:19 AM
Unknown Object (File)
Nov 4 2024, 1:28 PM
Unknown Object (File)
Sep 10 2024, 6:26 AM
Unknown Object (File)
Sep 6 2024, 8:34 AM
Unknown Object (File)
Sep 6 2024, 8:34 AM
Subscribers
None

Details

Summary

See PHI1900. Recent changes to how commit graphs are drawn made the height automatic in most cases, but it fails in Differential because the element isn't initially visible so the computed height is 0.

Just give them an explicit height so they show up again.

Test Plan

Viewed graphs in Maniphest, Differential, and Diffusion; saw them all render properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 9:10 PM
This revision was automatically updated to reflect the committed changes.