Use "getInlines()", not "_inlines", to access inlines on client Changeset objects
ClosedPublic
Actions

Authored by epriestley on Oct 2 2020, 4:11 PM.

Details

Reviewers: None
Commits: rP0f0e94ca71fe: Use "getInlines()", not "_inlines", to access inlines on client Changeset…

Summary

See PHI1898. An install is reporting an execution/initialization order issue where this code is reachable before _inlines is initialized.

I can't immediately reproduce it, but using "getInlines()" is preferable anyway and seems likely to fix the problem.

Test Plan

Viewed revisions with inlines, added/removed/edited/replied to inlines, didn't find anything broken.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 2 2020, 4:11 PM

Harbormaster completed remote builds in B24930: Diff 51115.Oct 2 2020, 4:12 PM

epriestley requested review of this revision.Oct 2 2020, 4:12 PM

Fix a possible call reentrancy issue, where "getInlines()" and "getInlineForRow()" could call one another.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2020, 4:19 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP0f0e94ca71fe: Use "getInlines()", not "_inlines", to access inlines on client Changeset… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0f0e94ca71fe: Use "getInlines()", not "_inlines", to access inlines on client Changeset….

Harbormaster completed remote builds in B24931: Diff 51116.Oct 2 2020, 4:20 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

19 lines

Diff 51117

View Options

resources/celerity/map.php