Page MenuHomePhabricator

Use "getInlines()", not "_inlines", to access inlines on client Changeset objects
ClosedPublic

Authored by epriestley on Fri, Oct 2, 4:11 PM.

Details

Summary

See PHI1898. An install is reporting an execution/initialization order issue where this code is reachable before _inlines is initialized.

I can't immediately reproduce it, but using "getInlines()" is preferable anyway and seems likely to fix the problem.

Test Plan

Viewed revisions with inlines, added/removed/edited/replied to inlines, didn't find anything broken.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

  • Fix a possible call reentrancy issue, where "getInlines()" and "getInlineForRow()" could call one another.
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Oct 2, 4:19 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.