Page MenuHomePhabricator
Differential D21474

Fix rubocop lint tests
ClosedPublic
Actions

Authored by bootstraponline on Sep 30 2020, 3:13 PM.
Tags
None
Referenced Files
F15455327: D21474.diff
Sat, Mar 29, 11:32 PM
F15450374: D21474.diff
Fri, Mar 28, 3:19 PM
F15445426: D21474.id51113.diff
Thu, Mar 27, 1:50 PM
F15445273: D21474.id51114.diff
Thu, Mar 27, 1:13 PM
F15439538: D21474.id.diff
Wed, Mar 26, 8:00 AM
F15436344: D21474.diff
Tue, Mar 25, 1:36 PM
F15423651: D21474.id51113.diff
Sat, Mar 22, 4:30 PM
F15349803: D21474.id51113.diff
Mar 10 2025, 3:08 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC04e340ab0f46: Fix rubocop lint tests
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Fix tests to work with rubocop 0.92.0 released on September 25, 2020

Test Plan

Unit tests pass

Diff Detail

Repository
rARC Arcanist
Branch
rubocop
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24928
Build 34391: Run Core Tests
Build 34390: arc lint + arc unit

Event Timeline

bootstraponline created this revision.Sep 30 2020, 3:13 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 30 2020, 3:13 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B24928: Diff 51113.Sep 30 2020, 3:14 PM
bootstraponline requested review of this revision.Sep 30 2020, 3:14 PM
epriestley accepted this revision.Sep 30 2020, 3:17 PM

Thanks!

You should be able to land this yourself directly, see the description of Blessed Committers for details or let me know if you run into issues. "Land Revision" in the web UI should also work.

This revision is now accepted and ready to land.Sep 30 2020, 3:17 PM
Herald added a subscriber: Korvin. · View Herald TranscriptSep 30 2020, 3:17 PM
Closed by commit rARC04e340ab0f46: Fix rubocop lint tests (authored by bootstraponline). · Explain WhySep 30 2020, 3:19 PM
This revision was automatically updated to reflect the committed changes.
bootstraponline added a commit: rARC04e340ab0f46: Fix rubocop lint tests.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
rubocop/
4 lines
2 lines
4 lines

Diff 51113

View Options

src/lint/linter/__tests__/rubocop/convention.lint-test

Loading...
View Options

src/lint/linter/__tests__/rubocop/no_errors.lint-test

Loading...
View Options

src/lint/linter/__tests__/rubocop/warning.lint-test

Loading...
Phabricator · Built by Phacility