Page MenuHomePhabricator

Allow AAST to extract string literal values from HEREDOCs
ClosedPublic

Authored by epriestley on Sep 5 2020, 12:26 AM.
Tags
None
Referenced Files
F15451719: D21455.id51060.diff
Fri, Mar 28, 11:32 PM
F15448025: D21455.id51065.diff
Fri, Mar 28, 2:58 AM
F15447469: D21455.id.diff
Fri, Mar 28, 12:03 AM
F15441676: D21455.diff
Mar 26 2025, 7:19 PM
F15331832: D21455.diff
Mar 7 2025, 2:13 PM
F15311998: D21455.id.diff
Mar 6 2025, 12:53 PM
F15311472: D21455.id51065.diff
Mar 6 2025, 10:06 AM
F15289679: D21455.id51060.diff
Mar 4 2025, 10:11 PM
Subscribers
None

Details

Summary

Ref T13577. I'd like to arc lint --everything to find other bad calls to pht() and similar functions, but n_HEREDOC nodes currently can not generate a response to "getStringLiteralValue()".

Support literal extraction from heredocs.

Test Plan

Added a test, made it pass. Will lint everything.

Diff Detail

Repository
rARC Arcanist
Branch
linter3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24875
Build 34319: Run Core Tests
Build 34318: arc lint + arc unit