Page MenuHomePhabricator

Allow AAST to extract string literal values from HEREDOCs
ClosedPublic

Authored by epriestley on Sep 5 2020, 12:26 AM.

Details

Summary

Ref T13577. I'd like to arc lint --everything to find other bad calls to pht() and similar functions, but n_HEREDOC nodes currently can not generate a response to "getStringLiteralValue()".

Support literal extraction from heredocs.

Test Plan

Added a test, made it pass. Will lint everything.

Diff Detail

Repository
rARC Arcanist
Branch
linter3
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24875
Build 34319: Run Core Tests
Build 34318: arc lint + arc unit