Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.
Tags
None
Referenced Files
F18109062: D21432.id50998.diff
Mon, Aug 11, 11:35 AM
F18108949: D21432.id50997.diff
Mon, Aug 11, 10:41 AM
F18104895: D21432.id.diff
Sun, Aug 10, 2:50 PM
F18099999: D21432.diff
Sat, Aug 9, 10:01 AM
F17754987: D21432.diff
Jul 22 2025, 11:43 AM
Unknown Object (File)
Jun 3 2025, 9:36 AM
Unknown Object (File)
Jun 3 2025, 4:07 AM
Unknown Object (File)
May 3 2025, 11:52 PM
Subscribers
Restricted Owners Package

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable