Page MenuHomePhabricator

Move "Wait for Previous Commits to Build" out of prototype
ClosedPublic

Authored by epriestley on Jul 30 2020, 7:43 PM.

Details

Summary

Although I'm not entirely thrilled about doing flow control like this (as an actual action in a build plan), I believe this build step works correctly and there's no fancy replacement mechanism on the immediate horizon, and this didn't send us down a slippery slope of Turing-complete builds encoded without real structure or context. Just kick it out of prototype.

(Other approaches which might be better in the long run are things like "this is a top-level behavior on the build plan itself" and/or "build plans are written in a DSL, not a Javascript UI".)

Test Plan

Added a new build step, saw this as an option in the "Flow Control" section.

Diff Detail

Repository
rP Phabricator
Branch
wait1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24814
Build 34235: Run Core Tests
Build 34234: arc lint + arc unit