Fix an issue with destruction of Revision and Diff objects with viewstates
ClosedPublic
Actions

Authored by epriestley on Jul 22 2020, 6:55 PM.

Details

Reviewers: None
Commits: rP324445589b5e: (stable) Fix an issue with destruction of Revision and Diff objects with…
rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates

Summary

See https://discourse.phabricator-community.org/t/domainexception-when-trying-to-remove-an-differentialrevision/4105.

These queries aren't actually constructed properly, and destroying a revision or diff with viewstates currently fails.

Test Plan

Used bin/remove destroy Dxxx to destroy a revision with viewstates (this also destroys the associated diffs).

Diff Detail

Repository

rP Phabricator

Branch

rmdiff

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24789
Build 34197: Run Core Tests
Build 34196: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 22 2020, 6:55 PM

Harbormaster completed remote builds in B24789: Diff 50969.Jul 22 2020, 6:56 PM

epriestley requested review of this revision.Jul 22 2020, 6:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2020, 8:07 PM

Closed by commit rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates.

epriestley added a commit: rP324445589b5e: (stable) Fix an issue with destruction of Revision and Diff objects with….Jul 22 2020, 8:20 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialDiff.php

3 lines

DifferentialRevision.php

3 lines

Diff 50969

View Options

src/applications/differential/storage/DifferentialDiff.php