Page MenuHomePhabricator

Fix an issue with destruction of Revision and Diff objects with viewstates
ClosedPublic

Authored by epriestley on Jul 22 2020, 6:55 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/domainexception-when-trying-to-remove-an-differentialrevision/4105.

These queries aren't actually constructed properly, and destroying a revision or diff with viewstates currently fails.

Test Plan

Used bin/remove destroy Dxxx to destroy a revision with viewstates (this also destroys the associated diffs).

Diff Detail

Repository
rP Phabricator
Branch
rmdiff
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24789
Build 34197: Run Core Tests
Build 34196: arc lint + arc unit