Page MenuHomePhabricator
Differential D21413

Move the view of merged changes to "DiffusionCommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 4:16 PM.
Tags
None
Referenced Files
F13188233: D21413.diff
Sat, May 11, 5:06 AM
F13182097: D21413.diff
Thu, May 9, 7:35 PM
Unknown Object (File)
Tue, May 7, 8:21 AM
Unknown Object (File)
Fri, May 3, 8:05 AM
Unknown Object (File)
Fri, Apr 26, 10:11 AM
Unknown Object (File)
Thu, Apr 25, 2:08 PM
Unknown Object (File)
Thu, Apr 25, 2:02 AM
Unknown Object (File)
Thu, Apr 25, 12:44 AM
View All 67 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView"
Summary

Ref T13552. When viewing a merge commit, merged changes are currently shown inline. Update this view to use the new "GraphView" rendering pipeline.

Test Plan
  • Viewed a merge commit, saw merges.
  • Viewed history, profile page, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 12 2020, 4:16 PM
Harbormaster completed remote builds in B24778: Diff 50958.Jul 12 2020, 4:17 PM
epriestley requested review of this revision.Jul 12 2020, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
Closed by commit rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView".

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
6 lines
20 lines
view/
172 lines

Diff 51030

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
Phabricator · Built by Phacility