Page MenuHomePhabricator
Differential D21413

Move the view of merged changes to "DiffusionCommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 4:16 PM.
Tags
None
Referenced Files
F13098791: D21413.id50958.diff
Fri, Apr 26, 10:11 AM
F13096052: D21413.id51030.diff
Thu, Apr 25, 2:08 PM
Unknown Object (File)
Thu, Apr 25, 2:02 AM
Unknown Object (File)
Thu, Apr 25, 12:44 AM
Unknown Object (File)
Sat, Apr 20, 3:12 PM
Unknown Object (File)
Wed, Apr 3, 9:07 AM
Unknown Object (File)
Mar 25 2024, 1:06 PM
Unknown Object (File)
Feb 24 2024, 6:58 AM
View All 63 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView"
Summary

Ref T13552. When viewing a merge commit, merged changes are currently shown inline. Update this view to use the new "GraphView" rendering pipeline.

Test Plan
  • Viewed a merge commit, saw merges.
  • Viewed history, profile page, etc.

Diff Detail

Repository
rP Phabricator
Branch
publish10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24778
Build 34178: Run Core Tests
Build 34177: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 12 2020, 4:16 PM
Harbormaster completed remote builds in B24778: Diff 50958.Jul 12 2020, 4:17 PM
epriestley requested review of this revision.Jul 12 2020, 4:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
Closed by commit rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView".

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
6 lines
20 lines
view/
172 lines

Diff 50958

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
Phabricator · Built by Phacility