Page MenuHomePhabricator

Allow "hg arc-ls-markers" to run under Python 2 or Python 3
ClosedPublic

Authored by epriestley on Jul 6 2020, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 5:24 PM
Unknown Object (File)
Sat, Apr 20, 5:37 AM
Unknown Object (File)
Fri, Apr 19, 10:42 AM
Unknown Object (File)
Thu, Apr 18, 12:56 AM
Unknown Object (File)
Wed, Apr 17, 3:01 PM
Unknown Object (File)
Mar 10 2024, 11:50 PM
Unknown Object (File)
Mar 10 2024, 5:11 AM
Unknown Object (File)
Feb 21 2024, 3:58 PM
Subscribers
None

Details

Summary

Ref T13546. See PHI1805. Currently, the "arc-ls-markers" extension doesn't run under Python 3:

  • some stuff needs "b'...'" to mark it as a byte string;
  • "dict.iteritems()" is gone in Python 3, and "mercurial.pycompat" isn't always available;
  • in Python 3, "json" refuses to print byte strings; and
  • the compiler caching behavior in Python 3 has changed.

Try to get these things working in the same way under Python 2 and Python 3.

Test Plan

Ran this command (with python as Python 2, locally):

$ python /usr/local/bin/hg --config 'extensions.arc-hg=/Users/epriestley/dev/core/lib/arcanist/support/hg/arc-hg.py' arc-ls-markers --

...and this command:

$ python3 /usr/local/bin/hg --config 'extensions.arc-hg=/Users/epriestley/dev/core/lib/arcanist/support/hg/arc-hg.py' arc-ls-markers --

..and saw the same output in both cases (previously, python3 ... fataled in various ways).

Diff Detail

Repository
rARC Arcanist
Branch
hg2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24740
Build 34118: Run Core Tests
Build 34117: arc lint + arc unit