Page MenuHomePhabricator

Allow the Fact daemon to hibernate
ClosedPublic

Authored by epriestley on Jul 1 2020, 1:27 PM.

Details

Summary

See PHI1801. A handful of Phacility production shards have run into memory pressure issues recently. Although there's no smoking gun, and at least two other plausible contributors, one possible concern is that the Fact daemon was written before hibernation and can not currently hibernate. Even if there's no memory leak, this creates unnecessary memory pressure by holding the processes in memory.

Allow the Fact daemon to hibernate, like other daemons do.

Test Plan

Ran "bin/phd debug fact", saw the Fact daemon hibernate.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 1 2020, 1:27 PM
epriestley requested review of this revision.Jul 1 2020, 1:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:33 PM
This revision was automatically updated to reflect the committed changes.
epriestley edited the summary of this revision. (Show Details)Jul 1 2020, 1:35 PM