Page MenuHomePhabricator

Allow the Fact daemon to hibernate
ClosedPublic

Authored by epriestley on Jul 1 2020, 1:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:11 PM
Unknown Object (File)
Sat, Apr 20, 5:24 PM
Unknown Object (File)
Sat, Apr 20, 10:56 AM
Unknown Object (File)
Fri, Apr 19, 9:11 PM
Unknown Object (File)
Thu, Apr 18, 4:35 AM
Unknown Object (File)
Wed, Apr 17, 3:14 PM
Unknown Object (File)
Thu, Apr 11, 7:23 AM
Unknown Object (File)
Thu, Apr 4, 12:00 AM
Subscribers

Details

Summary

See PHI1801. A handful of Phacility production shards have run into memory pressure issues recently. Although there's no smoking gun, and at least two other plausible contributors, one possible concern is that the Fact daemon was written before hibernation and can not currently hibernate. Even if there's no memory leak, this creates unnecessary memory pressure by holding the processes in memory.

Allow the Fact daemon to hibernate, like other daemons do.

Test Plan

Ran "bin/phd debug fact", saw the Fact daemon hibernate.

Diff Detail

Repository
rP Phabricator
Branch
hibernate1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24723
Build 34097: Run Core Tests
Build 34096: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:33 PM
This revision was automatically updated to reflect the committed changes.