Page MenuHomePhabricator

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:48 PM.
Tags
None
Referenced Files
F15396083: D21385.id50901.diff
Sun, Mar 16, 11:46 AM
F15378888: D21385.id50901.diff
Thu, Mar 13, 5:33 PM
F15334621: D21385.id50901.diff
Sat, Mar 8, 10:51 AM
F15332049: D21385.id50910.diff
Fri, Mar 7, 4:24 PM
F15331914: D21385.diff
Fri, Mar 7, 3:15 PM
F15331760: D21385.id.diff
Fri, Mar 7, 1:28 PM
Unknown Object (File)
Mon, Feb 24, 2:47 AM
Unknown Object (File)
Tue, Feb 18, 8:47 AM
Subscribers
None

Details

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan
  • Ran "arc upload <tab>", saw path completions.
  • Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable