Page MenuHomePhabricator

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:48 PM.
Tags
None
Referenced Files
F22829577: D21385.diff
Sat, Oct 10, 11:54 PM
F22663742: D21385.id50910.diff
Thu, Oct 1, 11:34 AM
F22514104: D21385.diff
Sat, Sep 19, 8:27 PM
Unknown Object (File)
Sep 7 2026, 7:46 AM
Unknown Object (File)
Aug 26 2026, 3:28 PM
Unknown Object (File)
Aug 15 2026, 4:44 AM
Unknown Object (File)
Jul 11 2026, 2:26 AM
Unknown Object (File)
Jun 22 2026, 5:16 PM
Subscribers
None

Details

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan
  • Ran "arc upload <tab>", saw path completions.
  • Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository
rARC Arcanist
Branch
future4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24719
Build 34089: Run Core Tests
Build 34088: arc lint + arc unit