When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic
Actions

Authored by epriestley on Jul 1 2020, 12:48 PM.

Details

Reviewers: None
Commits: rARC17f2668d1f75: When tab-completing "arc" commands, suggest paths if the argument is empty and…

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan

Ran "arc upload <tab>", saw path completions.
Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository

rARC Arcanist

Branch

future4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24719
Build 34089: Run Core Tests
Build 34088: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 1 2020, 12:48 PM

Harbormaster completed remote builds in B24719: Diff 50901.Jul 1 2020, 12:48 PM

epriestley requested review of this revision.Jul 1 2020, 12:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM

Closed by commit rARC17f2668d1f75: When tab-completing "arc" commands, suggest paths if the argument is empty and… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC17f2668d1f75: When tab-completing "arc" commands, suggest paths if the argument is empty and….

Revision Contents
Changeset List

Path

Size

src/

toolset/

workflow/

ArcanistShellCompleteWorkflow.php

14 lines

Diff 50901

View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument existsClosedPublicActions