Page MenuHomePhabricator

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 10:22 PM
Unknown Object (File)
Thu, Nov 14, 7:50 PM
Unknown Object (File)
Sat, Nov 9, 12:30 PM
Unknown Object (File)
Sat, Nov 9, 11:39 AM
Unknown Object (File)
Sat, Nov 9, 7:51 AM
Unknown Object (File)
Sat, Nov 9, 7:10 AM
Unknown Object (File)
Sat, Nov 9, 7:08 AM
Unknown Object (File)
Sat, Nov 9, 3:58 AM
Subscribers
None

Details

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan
  • Ran "arc upload <tab>", saw path completions.
  • Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable