Page MenuHomePhabricator

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:48 PM.
Tags
None
Referenced Files
F15470492: D21385.diff
Fri, Apr 4, 10:53 PM
F15467979: D21385.id50901.diff
Thu, Apr 3, 7:00 PM
F15457907: D21385.id50910.diff
Sun, Mar 30, 8:00 PM
F15453595: D21385.id.diff
Sat, Mar 29, 12:53 PM
F15451189: D21385.diff
Fri, Mar 28, 8:41 PM
F15417816: D21385.diff
Thu, Mar 20, 6:48 PM
F15396083: D21385.id50901.diff
Sun, Mar 16, 11:46 AM
F15378888: D21385.id50901.diff
Thu, Mar 13, 5:33 PM
Subscribers
None

Details

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan
  • Ran "arc upload <tab>", saw path completions.
  • Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable