Page MenuHomePhabricator

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:48 PM.
Tags
None
Referenced Files
F18757690: D21385.id.diff
Oct 5 2025, 7:02 PM
F18756067: D21385.id50910.diff
Oct 5 2025, 9:02 AM
F18685833: D21385.id50901.diff
Sep 26 2025, 11:47 AM
F18653929: D21385.diff
Sep 21 2025, 10:36 PM
F18638766: D21385.diff
Sep 17 2025, 11:26 AM
F18575991: D21385.id50910.diff
Sep 10 2025, 2:37 PM
F18194065: D21385.diff
Aug 17 2025, 8:18 AM
F17846560: D21385.id.diff
Jul 27 2025, 5:01 AM
Subscribers
None

Details

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan
  • Ran "arc upload <tab>", saw path completions.
  • Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable