Page MenuHomePhabricator

When tab-completing "arc" commands, suggest paths if the argument is empty and a path wildcard argument exists
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:48 PM.

Details

Summary

Currently, if you type "arc upload <tab>", we do not autocomplete the working directory. We should, but the "current argument" is the empty string and that's technically a prefix of every flag, so we suggest that you might want a flag instead.

You probably don't. Suggest paths in this case.

Test Plan
  • Ran "arc upload <tab>", saw path completions.
  • Ran "arc land <tab>" (this workflow does NOT take paths as arguments), saw flag completions.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 1 2020, 12:48 PM
epriestley requested review of this revision.Jul 1 2020, 12:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.