Page MenuHomePhabricator
Differential D21354

In "arc land" under Git, confirm branch creation
ClosedPublic
Actions

Authored by epriestley on Jun 11 2020, 2:48 PM.
Tags
None
Referenced Files
F15497507: D21354.id.diff
Sun, Apr 13, 10:39 AM
F15497364: D21354.diff
Sun, Apr 13, 10:21 AM
F15471735: D21354.id50832.diff
Sat, Apr 5, 7:51 AM
F15458092: D21354.id50867.diff
Sun, Mar 30, 8:42 PM
F15456205: D21354.id50831.diff
Sun, Mar 30, 7:50 AM
F15438850: D21354.id50832.diff
Wed, Mar 26, 4:03 AM
F15437887: D21354.id50832.diff
Tue, Mar 25, 9:57 PM
F15437828: D21354.id.diff
Tue, Mar 25, 9:44 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rARCb0a9ef8351f1: In "arc land" under Git, confirm branch creation
Summary

Ref T13546. If "arc land" would create a branch, warn the user before it does.

Test Plan

Ran "arc land --onto mtarse", a typo of "master".

Diff Detail

Repository
rARC Arcanist
Branch
landx7
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/repository/marker/ArcanistGitRepositoryMarkerQuery.php:173XHP5Use of Undeclared Variable
Unit
Tests Passed
Build Status
Buildable 24651
Build 33987: Run Core Tests
Build 33986: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 11 2020, 2:48 PM
Harbormaster completed remote builds in B24651: Diff 50831.Jun 11 2020, 2:48 PM
epriestley requested review of this revision.Jun 11 2020, 2:48 PM
epriestley updated this revision to Diff 50832.Jun 11 2020, 2:48 PM
  • Fix undeclared "$markers".
Harbormaster completed remote builds in B24652: Diff 50832.Jun 11 2020, 2:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 1:29 PM
Closed by commit rARCb0a9ef8351f1: In "arc land" under Git, confirm branch creation (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCb0a9ef8351f1: In "arc land" under Git, confirm branch creation.

Revision Contents
Changeset List

PathSize
src/
land/
engine/
61 lines
5 lines
18 lines
repository/
marker/
53 lines
xsprintf/
1 line

Diff 50831

View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/repository/marker/ArcanistGitRepositoryMarkerQuery.php

Loading...
View Options

src/xsprintf/tsprintf.php

Loading...
Phabricator · Built by Phacility