Page MenuHomePhabricator
Differential D21353

Collect scattered implementations of "getDisplayHash()" into RepositoryAPI
ClosedPublic
Actions

Authored by epriestley on Jun 11 2020, 1:36 PM.
Tags
None
Referenced Files
F19073778: D21353.diff
Mon, Dec 1, 2:58 AM
F18978884: D21353.id.diff
Sun, Nov 16, 8:56 PM
F18978201: D21353.diff
Sun, Nov 16, 7:29 PM
F18946150: D21353.id50866.diff
Tue, Nov 11, 7:37 PM
F18925379: D21353.id.diff
Sun, Nov 9, 6:42 PM
F18852271: D21353.id50830.diff
Oct 31 2025, 7:45 AM
F18778112: D21353.id50830.diff
Oct 11 2025, 8:08 AM
F18767104: D21353.id.diff
Oct 7 2025, 8:36 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rARC33bb0acf97b3: Collect scattered implementations of "getDisplayHash()" into RepositoryAPI
Summary

Ref T13546. All of LandEngine, LocalState, and RepositoryAPI implement "getDisplayHash()". Always use the RepositoryAPI implementation.

Test Plan

Grepped for symbols.

Diff Detail

Repository
rARC Arcanist
Branch
landx6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24650
Build 33985: Run Core Tests
Build 33984: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 11 2020, 1:36 PM
Harbormaster completed remote builds in B24650: Diff 50830.Jun 11 2020, 1:37 PM
epriestley requested review of this revision.Jun 11 2020, 1:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 1:28 PM
Closed by commit rARC33bb0acf97b3: Collect scattered implementations of "getDisplayHash()" into RepositoryAPI (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC33bb0acf97b3: Collect scattered implementations of "getDisplayHash()" into RepositoryAPI.

Revision Contents
Changeset List

Diff 50830

View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/repository/state/ArcanistGitLocalState.php

Loading...
View Options

src/repository/state/ArcanistMercurialLocalState.php

Loading...
View Options

src/repository/state/ArcanistRepositoryLocalState.php

Loading...
Phabricator · Built by Phacility