Add an explicit "uri" to the "harbormaster.buildable.search" results
ClosedPublic
Actions

Authored by epriestley on Jun 10 2020, 5:12 PM.

Tags

None

Referenced Files

	F15483571: D21346.diff
	Wed, Apr 9, 1:09 PM

	F15458318: D21346.diff
	Sun, Mar 30, 11:02 PM

	F15446273: D21346.id50810.diff
	Thu, Mar 27, 6:07 PM

	F15442921: D21346.id50824.diff
	Thu, Mar 27, 1:16 AM

	F15440008: D21346.id.diff
	Wed, Mar 26, 10:42 AM

	F15431764: D21346.diff
	Mon, Mar 24, 2:22 PM

	F15430298: D21346.diff
	Mon, Mar 24, 6:58 AM

	F15387319: D21346.diff
	Sat, Mar 15, 2:12 AM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rP5b1dd96e40e8: Add an explicit "uri" to the "harbormaster.buildable.search" results

Summary

Ref T13546. This makes some "arc" tasks a little easier, and will make them more correct if "arc" ever switches to using SSH.

Test Plan

Ran "harbormaster.buildable.search" from the web UI, saw URIs in the result set.

Diff Detail

Repository

rP Phabricator

Branch

uri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24631
Build 33957: Run Core Tests
Build 33956: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 10 2020, 5:12 PM

Owners added a subscriber: Restricted Owners Package.Jun 10 2020, 5:12 PM

Harbormaster completed remote builds in B24631: Diff 50810.Jun 10 2020, 5:13 PM

epriestley requested review of this revision.Jun 10 2020, 5:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 11 2020, 12:31 AM

Closed by commit rP5b1dd96e40e8: Add an explicit "uri" to the "harbormaster.buildable.search" results (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5b1dd96e40e8: Add an explicit "uri" to the "harbormaster.buildable.search" results.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

HarbormasterBuildable.php

5 lines

Diff 50810

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Add an explicit "uri" to the "harbormaster.buildable.search" resultsClosedPublicActions