Differential D21342

Verify remotes ("paths") in Mercurial during "arc land"
ClosedPublic
Actions

Authored by epriestley on Jun 9 2020, 1:35 PM.

Tags

None

Referenced Files

	F15379470: D21342.id50806.diff
	Thu, Mar 13, 9:23 PM

	F15379469: D21342.id50815.diff
	Thu, Mar 13, 9:23 PM

	F15375780: D21342.id.diff
	Thu, Mar 13, 12:12 AM

	Unknown Object (File)
	Thu, Feb 27, 8:36 PM

	Unknown Object (File)
	Wed, Feb 26, 7:24 PM

	Unknown Object (File)
	Sat, Feb 22, 7:26 PM

	Unknown Object (File)
	Mon, Feb 17, 10:14 PM

	Unknown Object (File)
	Feb 14 2025, 11:29 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC1bb054ef47a1: Verify remotes ("paths") in Mercurial during "arc land"

Summary

Ref T13546. Parse "hg paths" and validate that the remotes "arc land" plans to interact with actually exist.

Test Plan

Ran "arc land" with good and bad "--into-remote" and "--onto-remote" arguments, got sensible validation behavior.

Diff Detail

Repository

Branch

hg1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/land/engine/ArcanistMercurialLandEngine.php:142	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:287	XHP16	TODO Comment
Advice	src/repository/api/ArcanistMercurialAPI.php:905	XHP16	TODO Comment
Advice	src/workflow/ArcanistWorkflow.php:2039	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24627
Build 33949: Run Core Tests
Build 33948: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 9 2020, 1:35 PM

Harbormaster completed remote builds in B24627: Diff 50806.Jun 9 2020, 1:36 PM

epriestley requested review of this revision.Jun 9 2020, 1:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2020, 5:27 PM

Closed by commit rARC1bb054ef47a1: Verify remotes ("paths") in Mercurial during "arc land" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC1bb054ef47a1: Verify remotes ("paths") in Mercurial during "arc land".

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

land/

engine/

ArcanistMercurialLandEngine.php

28 lines

repository/

api/

ArcanistMercurialAPI.php

6 lines

ArcanistRepositoryAPI.php

9 lines

marker/

ArcanistRepositoryMarkerQuery.php

28 lines

query/

ArcanistRepositoryQuery.php

35 lines

remote/

ArcanistMercurialRepositoryRemoteQuery.php

45 lines

ArcanistRemoteRef.php

41 lines

ArcanistRepositoryRemoteQuery.php

31 lines

workflow/

ArcanistWorkflow.php

2 lines

Diff 50806

src/__phutil_library_map__.php

Loading...

src/land/engine/ArcanistMercurialLandEngine.php

Loading...

src/repository/api/ArcanistMercurialAPI.php

Loading...

src/repository/api/ArcanistRepositoryAPI.php

Loading...

src/repository/marker/ArcanistRepositoryMarkerQuery.php

Loading...

src/repository/query/ArcanistRepositoryQuery.php

Loading...

src/repository/remote/ArcanistMercurialRepositoryRemoteQuery.php

Loading...

src/repository/remote/ArcanistRemoteRef.php

Loading...

src/repository/remote/ArcanistRepositoryRemoteQuery.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...