Page MenuHomePhabricator

Improve "arc land" behavior in the presence of merge conflicts and change sequences
ClosedPublic

Authored by epriestley on Jun 8 2020, 10:42 PM.
Tags
None
Referenced Files
F17947993: D21339.id.diff
Thu, Jul 31, 7:46 PM
F17939311: D21339.id.diff
Thu, Jul 31, 3:02 AM
F17932505: D21339.diff
Wed, Jul 30, 8:19 PM
F17868818: D21339.diff
Mon, Jul 28, 9:49 AM
Unknown Object (File)
Jul 2 2025, 12:58 AM
Unknown Object (File)
Jun 14 2025, 4:15 AM
Unknown Object (File)
Jun 5 2025, 4:58 PM
Unknown Object (File)
May 6 2025, 5:48 PM
Subscribers
None

Details

Summary

Ref T13546. When we encounter a merge conflict, suggest "--incremental" if it's likely to help.

When merging multiple changes, rebase ranges before merging them. This reduces conflicts when landing sequences of changes.

Test Plan

Ran "arc land" to land multiple changes. Hit better merge conflict messaging, then survived merge conflicts entirely.

Diff Detail

Repository
rARC Arcanist
Branch
land33
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24597
Build 33916: Run Core Tests
Build 33915: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:30 PM
This revision was automatically updated to reflect the committed changes.