Implement "arc work", to replace "arc feature"
ClosedPublic
Actions

Authored by epriestley on Jun 8 2020, 9:23 PM.

Details

Reviewers: None
Maniphest Tasks: T2928: "arc start" / "arc feature" / "arc push" Discussion
T13546: Modernize the "arc land" workflow
Commits: rARC3d64140ff31c: Implement "arc work", to replace "arc feature"

Summary

Ref T13546. Fixes T2928. Adds a new "arc work" workflow which functions like the older "arc feature" workflow, but with modern infrastructure.

Test Plan

Used "arc work" to begin work on branches, bookmarks, and revisions in Git and Mercurial.

Diff Detail

Repository

rARC Arcanist

Branch

land29

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/work/ArcanistWorkEngine.php:44	XHP16	TODO Comment
Advice	src/work/ArcanistWorkEngine.php:146	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24589
Build 33904: Run Core Tests
Build 33903: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 8 2020, 9:23 PM

Harbormaster completed remote builds in B24589: Diff 50768.Jun 8 2020, 9:23 PM

epriestley requested review of this revision.Jun 8 2020, 9:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:27 PM

Closed by commit rARC3d64140ff31c: Implement "arc work", to replace "arc feature" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC3d64140ff31c: Implement "arc work", to replace "arc feature".

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

engine/

ArcanistWorkflowEngine.php

48 lines

hardpoint/

ArcanistHardpointObject.php

6 lines

land/

engine/

ArcanistLandEngine.php

45 lines

repository/

api/

ArcanistGitAPI.php

4 lines

ArcanistMercurialAPI.php

4 lines

ArcanistRepositoryAPI.php

18 lines

marker/

ArcanistMarkerRef.php

48 lines

ArcanistMercurialRepositoryMarkerQuery.php

2 lines

ArcanistRepositoryMarkerQuery.php

44 lines

state/

ArcanistGitLocalState.php

2 lines

work/

ArcanistGitWorkEngine.php

57 lines

ArcanistMercurialWorkEngine.php

56 lines

ArcanistWorkEngine.php

215 lines

workflow/

ArcanistWorkWorkflow.php

95 lines

Diff 50768

View Options

src/__phutil_library_map__.php

View Options

src/engine/ArcanistWorkflowEngine.php

View Options

src/hardpoint/ArcanistHardpointObject.php

View Options

src/land/engine/ArcanistLandEngine.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/repository/api/ArcanistRepositoryAPI.php

View Options

src/repository/marker/ArcanistMarkerRef.php

View Options

src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php

View Options

src/repository/marker/ArcanistRepositoryMarkerQuery.php

View Options

src/repository/state/ArcanistGitLocalState.php

View Options

src/work/ArcanistGitWorkEngine.php

View Options

src/work/ArcanistMercurialWorkEngine.php

View Options

src/work/ArcanistWorkEngine.php

View Options

src/workflow/ArcanistWorkWorkflow.php

Implement "arc work", to replace "arc feature"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50768

src/__phutil_library_map__.php

src/engine/ArcanistWorkflowEngine.php

src/hardpoint/ArcanistHardpointObject.php

src/land/engine/ArcanistLandEngine.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/repository/api/ArcanistRepositoryAPI.php

src/repository/marker/ArcanistMarkerRef.php

src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php

src/repository/marker/ArcanistRepositoryMarkerQuery.php

src/repository/state/ArcanistGitLocalState.php

src/work/ArcanistGitWorkEngine.php

src/work/ArcanistMercurialWorkEngine.php

src/work/ArcanistWorkEngine.php

src/workflow/ArcanistWorkWorkflow.php

Implement "arc work", to replace "arc feature"
ClosedPublic
Actions

Revision Contents
Changeset List