Page MenuHomePhabricator

Provide a more powerful query mechanism for "markers" (branches/bookmarks)
ClosedPublic

Authored by epriestley on Jun 8 2020, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 12:20 PM
Unknown Object (File)
Jan 31 2024, 5:23 PM
Unknown Object (File)
Jan 31 2024, 8:07 AM
Unknown Object (File)
Jan 16 2024, 11:34 PM
Unknown Object (File)
Jan 16 2024, 10:45 PM
Unknown Object (File)
Jan 16 2024, 10:14 PM
Unknown Object (File)
Jan 11 2024, 12:37 AM
Unknown Object (File)
Dec 24 2023, 1:51 PM
Subscribers
None

Details

Summary

Ref T13546. Various Arcanist workflows, and particularly the MercurialAPI, currently repeat quite a lot of code around parsing branches and bookmarks.

In modern Mercurial, we can generally use the "head()" and "bookmark()" revsets to do this fairly sensibly.

This change mostly adds more code (and introduces "arc bookmarks" and "arc branches" as replacements for "arc bookmark" and "arc branch") but followups should be able to mostly delete code.

Test Plan

Ran "arc branches" and "arc bookmarks" in Git and Mercurial.

Diff Detail

Repository
rARC Arcanist
Branch
land27
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24585
Build 33896: Run Core Tests
Build 33895: arc lint + arc unit

Event Timeline

  • Improve Mercurial behavior for figuring out which branch head is active.
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:27 PM
This revision was automatically updated to reflect the committed changes.