Page MenuHomePhabricator

Improve the logic for identifying ambiguous commits and applying "--revision" to them
ClosedPublic

Authored by epriestley on Jun 7 2020, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 4:45 AM
Unknown Object (File)
Oct 15 2024, 11:22 AM
Unknown Object (File)
Oct 9 2024, 1:30 PM
Unknown Object (File)
Oct 9 2024, 1:30 PM
Unknown Object (File)
Oct 9 2024, 1:30 PM
Unknown Object (File)
Oct 7 2024, 10:07 PM
Unknown Object (File)
Sep 28 2024, 3:00 PM
Unknown Object (File)
Sep 24 2024, 12:05 PM
Subscribers
None

Details

Summary

Ref T13546. This is mostly minor cleanup that improves behavior under "--revision".

Test Plan

Ran arc land --into-empty and arc land --into-empty --revision 123 with ambiguous revisions in history to hit both the force and non-force outcomes.

Diff Detail

Repository
rARC Arcanist
Branch
land18
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/land/engine/ArcanistLandEngine.php:907XHP16TODO Comment
Advicesrc/land/engine/ArcanistLandEngine.php:947XHP16TODO Comment
Advicesrc/land/engine/ArcanistLandEngine.php:950XHP16TODO Comment
Advicesrc/land/engine/ArcanistLandEngine.php:952XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24577
Build 33880: Run Core Tests
Build 33879: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM
This revision was automatically updated to reflect the committed changes.