Paths

Table of Contentst

Differential D21325

Improve the logic for identifying ambiguous commits and applying "--revision" to them
ClosedPublic
Actions

Authored by epriestley on Jun 7 2020, 3:53 PM.

Tags

None

Referenced Files

	F13182055: D21325.id50755.diff
	Thu, May 9, 7:07 PM

	F13175744: D21325.id50789.diff
	Wed, May 8, 7:08 AM

	F13174499: D21325.id.diff
	Tue, May 7, 11:28 PM

	Unknown Object (File)
	Fri, May 3, 5:57 AM

	Unknown Object (File)
	Fri, Apr 26, 8:28 AM

	Unknown Object (File)
	Thu, Apr 25, 12:59 AM

	Unknown Object (File)
	Sat, Apr 20, 5:18 PM

	Unknown Object (File)
	Mar 29 2024, 9:21 AM

View All 49 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"…

Summary

Ref T13546. This is mostly minor cleanup that improves behavior under "--revision".

Test Plan

Ran arc land --into-empty and arc land --into-empty --revision 123 with ambiguous revisions in history to hit both the force and non-force outcomes.

Diff Detail

Repository

Branch

land18

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/land/engine/ArcanistLandEngine.php:907	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:947	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:950	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:952	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24577
Build 33880: Run Core Tests
Build 33879: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2020, 3:53 PM

Harbormaster completed remote builds in B24577: Diff 50755.Jun 7 2020, 3:53 PM

epriestley requested review of this revision.Jun 7 2020, 3:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM

Closed by commit rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"….

Revision Contents
Changeset List

Path

Size

src/

land/

ArcanistLandCommit.php

10 lines

engine/

ArcanistLandEngine.php

179 lines

Diff 50755

src/land/ArcanistLandCommit.php

Loading...

src/land/engine/ArcanistLandEngine.php

Loading...