Differential D21315

Substantially modernize the "arc land" workflow
ClosedPublic
Actions

Authored by epriestley on Jun 5 2020, 7:02 PM.

Tags

None

Referenced Files

	F15466282: D21315.id50781.diff
	Thu, Apr 3, 3:54 AM

	F15429545: D21315.diff
	Mon, Mar 24, 2:54 AM

	F15417438: D21315.id50781.diff
	Thu, Mar 20, 5:00 PM

	F15409590: D21315.diff
	Wed, Mar 19, 4:44 AM

	F15402807: D21315.id50781.diff
	Tue, Mar 18, 12:27 AM

	F15379240: D21315.id50733.diff
	Thu, Mar 13, 7:39 PM

	F15379239: D21315.id.diff
	Thu, Mar 13, 7:39 PM

	F15379238: D21315.id50781.diff
	Thu, Mar 13, 7:39 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC68f28a171888: Substantially modernize the "arc land" workflow

Summary

Ref T13546. This has a lot of dangerously rough edges, but has managed to land at least one commit in each Git and Mercurial.

Test Plan

Landed one commit under ideal conditions in Git and Mercurial.
See followups.

Diff Detail

Repository

Branch

land9

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/land/engine/ArcanistGitLandEngine.php:146	XHP16	TODO Comment
Advice	src/land/engine/ArcanistGitLandEngine.php:250	XHP16	TODO Comment
Advice	src/land/engine/ArcanistGitLandEngine.php:321	XHP16	TODO Comment
Advice	src/land/engine/ArcanistGitLandEngine.php:398	XHP16	TODO Comment
Advice	src/land/engine/ArcanistGitLandEngine.php:1029	XHP16	TODO Comment
Advice	src/land/engine/ArcanistGitLandEngine.php:1246	XHP16	TODO Comment
Advice	src/land/engine/ArcanistGitLandEngine.php:1261	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:698	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:703	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:857	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:865	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:893	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:923	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:939	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:1091	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:1216	XHP16	TODO Comment
Advice	src/land/engine/ArcanistLandEngine.php:1269	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:48	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:57	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:73	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:208	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:209	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:300	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:361	XHP16	TODO Comment
Advice	src/land/engine/ArcanistMercurialLandEngine.php:362	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24555
Build 33849: Run Core Tests
Build 33848: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 5 2020, 7:02 PM

Harbormaster completed remote builds in B24555: Diff 50733.Jun 5 2020, 7:02 PM

epriestley requested review of this revision.Jun 5 2020, 7:02 PM

epriestley mentioned this in T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`.Jun 5 2020, 8:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:17 PM

Closed by commit rARC68f28a171888: Substantially modernize the "arc land" workflow (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC68f28a171888: Substantially modernize the "arc land" workflow.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

config/

arc/

ArcanistArcConfigurationEngineExtension.php

14 lines

land/

ArcanistGitLandEngine.php

ArcanistLandCommit.php

149 lines

ArcanistLandCommitSet.php

52 lines

ArcanistLandEngine.php

ArcanistLandSymbol.php

27 lines

ArcanistLandTarget.php

41 lines

engine/

ArcanistGitLandEngine.php

1362 lines

ArcanistLandEngine.php

1430 lines

ArcanistMercurialLandEngine.php

603 lines

query/

ArcanistMercurialCommitMessageHardpointQuery.php

36 lines

ArcanistMercurialWorkingCopyRevisionHardpointQuery.php

76 lines

ArcanistWorkflowMercurialHardpointQuery.php

11 lines

ref/

revision/

ArcanistRevisionBuildableHardpointQuery.php

2 lines

repository/

api/

ArcanistGitAPI.php

14 lines

ArcanistMercurialAPI.php

64 lines

ArcanistRepositoryAPI.php

15 lines

state/

ArcanistMercurialLocalState.php

60 lines

ArcanistRepositoryLocalState.php

3 lines

workflow/

ArcanistLandWorkflow.php

1789 lines

ArcanistWorkflow.php

13 lines

Diff 50733

src/__phutil_library_map__.php

Loading...

src/config/arc/ArcanistArcConfigurationEngineExtension.php

Loading...

src/land/ArcanistGitLandEngine.php

Loading...

src/land/ArcanistLandCommit.php

Loading...

src/land/ArcanistLandCommitSet.php

Loading...

src/land/ArcanistLandEngine.php

Loading...

src/land/ArcanistLandSymbol.php

Loading...

src/land/ArcanistLandTarget.php

Loading...

src/land/engine/ArcanistGitLandEngine.php

Loading...

src/land/engine/ArcanistLandEngine.php

Loading...

src/land/engine/ArcanistMercurialLandEngine.php

Loading...

src/query/ArcanistMercurialCommitMessageHardpointQuery.php

Loading...

src/query/ArcanistMercurialWorkingCopyRevisionHardpointQuery.php

Loading...

src/query/ArcanistWorkflowMercurialHardpointQuery.php

Loading...

src/ref/revision/ArcanistRevisionBuildableHardpointQuery.php

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/repository/api/ArcanistMercurialAPI.php

Loading...

src/repository/api/ArcanistRepositoryAPI.php

Loading...

src/repository/state/ArcanistMercurialLocalState.php

Loading...

src/repository/state/ArcanistRepositoryLocalState.php

Loading...

src/workflow/ArcanistLandWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...