Page MenuHomePhabricator

Support appending arbitrary lines to DisplayRef output
ClosedPublic

Authored by epriestley on Jun 4 2020, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 5:16 PM
Unknown Object (File)
Fri, Apr 19, 9:01 PM
Unknown Object (File)
Fri, Apr 12, 8:36 AM
Unknown Object (File)
Tue, Apr 2, 10:45 PM
Unknown Object (File)
Feb 19 2024, 10:52 AM
Unknown Object (File)
Feb 14 2024, 12:35 PM
Unknown Object (File)
Jan 17 2024, 6:13 AM
Unknown Object (File)
Jan 11 2024, 12:41 AM
Subscribers
None

Details

Summary

Ref T13546. Several substeps in the new "arc land" flow benefit from this. For example:

  • When prompting "land revisions you don't own?", it's used to show authors.
  • When prompting "land revisions in the wrong state?", it's used to show the current states.
Test Plan

Ran future "arc land" workflows, got relevant contextual information via this mechanism.

Diff Detail

Repository
rARC Arcanist
Branch
land2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24548
Build 33835: Run Core Tests
Build 33834: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 7:22 PM
This revision was automatically updated to reflect the committed changes.