Remove the "--less-context" flag from "arc diff"
ClosedPublic
Actions

Authored by epriestley on May 30 2020, 10:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 13, 9:17 AM

	Unknown Object (File)
	Fri, Jan 10, 2:07 AM

	Unknown Object (File)
	Wed, Jan 8, 9:02 PM

	Unknown Object (File)
	Sun, Dec 29, 8:32 PM

	Unknown Object (File)
	Nov 14 2024, 8:23 AM

	Unknown Object (File)
	Nov 11 2024, 3:01 AM

	Unknown Object (File)
	Nov 4 2024, 11:01 PM

	Unknown Object (File)
	Oct 31 2024, 6:27 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13544: Modernize the "arc diff" workflow
Commits: rARC0a4a841f8f1d: Remove the "--less-context" flag from "arc diff"

Summary

Ref T13544. This is an obscure flag and almost never useful. You can accomplish the same goal, roughly, with "git diff | arc diff --raw -". See also PHI675. See also T13338.

Test Plan

Grepped for "less-context", created this revision.

Diff Detail

Repository

rARC Arcanist

Branch

xdiff6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24540
Build 33821: Run Core Tests
Build 33820: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2020, 10:42 PM

Harbormaster completed remote builds in B24540: Diff 50718.May 30 2020, 10:43 PM

epriestley requested review of this revision.May 30 2020, 10:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 8:32 PM

Closed by commit rARC0a4a841f8f1d: Remove the "--less-context" flag from "arc diff" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC0a4a841f8f1d: Remove the "--less-context" flag from "arc diff".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

18 lines

Diff 50718

View Options

src/workflow/ArcanistDiffWorkflow.php

Remove the "--less-context" flag from "arc diff"ClosedPublicActions