Remove "--encoding" flag from "arc diff"
ClosedPublic
Actions

Authored by epriestley on May 30 2020, 10:30 PM.

Tags

None

Referenced Files

	F15381368: D21300.id.diff
	Fri, Mar 14, 7:17 AM

	F15377235: D21300.id50716.diff
	Thu, Mar 13, 8:26 AM

	F15333022: D21300.diff
	Fri, Mar 7, 11:11 PM

	F15325119: D21300.id50716.diff
	Fri, Mar 7, 2:15 AM

	F15324850: D21300.id50716.diff
	Fri, Mar 7, 1:59 AM

	Unknown Object (File)
	Sat, Mar 1, 6:21 AM

	Unknown Object (File)
	Tue, Feb 18, 1:31 PM

	Unknown Object (File)
	Feb 9 2025, 9:25 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13544: Modernize the "arc diff" workflow
Commits: rARCb689a8c78b6c: (stable) Remove "--encoding" flag from "arc diff"
rARC466de2d2e1ec: Remove "--encoding" flag from "arc diff"

Summary

Ref T13544. This flag is generally questionable, likely has no actual uses, and is slated for obsoletion and replacement elsewhere (see T13338).

Test Plan

Grepped for "encoding", found no relevant hits.

Diff Detail

Repository

rARC Arcanist

Branch

xdiff5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24538
Build 33818: Run Core Tests
Build 33817: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2020, 10:30 PM

Harbormaster completed remote builds in B24538: Diff 50716.May 30 2020, 10:30 PM

epriestley requested review of this revision.May 30 2020, 10:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 8:27 PM

Closed by commit rARC466de2d2e1ec: Remove "--encoding" flag from "arc diff" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC466de2d2e1ec: Remove "--encoding" flag from "arc diff".

epriestley added a commit: rARCb689a8c78b6c: (stable) Remove "--encoding" flag from "arc diff".Jun 7 2020, 1:44 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

27 lines

Diff 50716

View Options

src/workflow/ArcanistDiffWorkflow.php

Remove "--encoding" flag from "arc diff"ClosedPublicActions