Page MenuHomePhabricator

Roughly support inline comment suggestions
ClosedPublic

Authored by epriestley on May 20 2020, 3:16 PM.

Details

Summary

Ref T13513. This still has quite a few rough edges and some significant performance isssues, but appears to mostly work.

Allow reviewers to "Suggest Edit" on an inline comment and provide replacement text for the highlighted source.

Test Plan

Created, edited, reloaded, and submitted inline comments in various states with and without suggestion text.

Diff Detail

Repository
rP Phabricator
Branch
inline10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24480
Build 33734: Run Core Tests
Build 33733: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:26 PM
This revision was automatically updated to reflect the committed changes.