Page MenuHomePhabricator

Roughly support inline comment suggestions
ClosedPublic

Authored by epriestley on May 20 2020, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 1:20 AM
Unknown Object (File)
Jan 17 2024, 5:15 PM
Unknown Object (File)
Jan 9 2024, 8:10 AM
Unknown Object (File)
Dec 27 2023, 8:19 AM
Unknown Object (File)
Dec 27 2023, 1:07 AM
Unknown Object (File)
Dec 17 2023, 10:43 AM
Unknown Object (File)
Nov 30 2023, 12:57 AM
Unknown Object (File)
Nov 29 2023, 9:30 PM
Subscribers
None

Details

Summary

Ref T13513. This still has quite a few rough edges and some significant performance isssues, but appears to mostly work.

Allow reviewers to "Suggest Edit" on an inline comment and provide replacement text for the highlighted source.

Test Plan

Created, edited, reloaded, and submitted inline comments in various states with and without suggestion text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:26 PM
This revision was automatically updated to reflect the committed changes.