Page MenuHomePhabricator

Make inline content "state-oriented", not "string-oriented"
ClosedPublic

Authored by epriestley on May 19 2020, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 12:28 PM
Unknown Object (File)
Jan 6 2024, 3:40 AM
Unknown Object (File)
Dec 25 2023, 4:17 PM
Unknown Object (File)
Dec 20 2023, 6:12 AM
Unknown Object (File)
Dec 16 2023, 12:42 PM
Unknown Object (File)
Nov 30 2023, 12:53 AM
Unknown Object (File)
Nov 25 2023, 11:34 PM
Unknown Object (File)
Nov 15 2023, 10:42 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, all the inline code passes around strings to describe content. I plan to add background music, animation effects, etc., soon. To prepare for this change, make content a state object.

This does not change any user-visible behavior, it just prepares for content to become more complicated than a single string.

Test Plan

Created, edited, submitted, cancelled, etc., comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:24 PM
This revision was automatically updated to reflect the committed changes.