Page MenuHomePhabricator

Make inline content "state-oriented", not "string-oriented"
ClosedPublic

Authored by epriestley on May 19 2020, 8:51 PM.
Tags
None
Referenced Files
F18797530: D21273.diff
Fri, Oct 17, 5:09 AM
F18759949: D21273.id.diff
Mon, Oct 6, 7:03 AM
F18704517: D21273.id50667.diff
Sun, Sep 28, 7:54 AM
F18613947: D21273.id.diff
Sep 14 2025, 11:44 AM
F18598415: D21273.diff
Sep 13 2025, 4:59 AM
F18112354: D21273.diff
Aug 12 2025, 4:28 PM
F18110194: D21273.id50658.diff
Aug 11 2025, 5:12 PM
F18105371: D21273.id50667.diff
Aug 10 2025, 5:50 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, all the inline code passes around strings to describe content. I plan to add background music, animation effects, etc., soon. To prepare for this change, make content a state object.

This does not change any user-visible behavior, it just prepares for content to become more complicated than a single string.

Test Plan

Created, edited, submitted, cancelled, etc., comments.

Diff Detail

Repository
rP Phabricator
Branch
inline7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24477
Build 33728: Run Core Tests
Build 33727: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:24 PM
This revision was automatically updated to reflect the committed changes.