Page MenuHomePhabricator

Make inline content "state-oriented", not "string-oriented"
ClosedPublic

Authored by epriestley on May 19 2020, 8:51 PM.
Tags
None
Referenced Files
F19825346: D21273.id50667.diff
Sun, Mar 8, 10:34 AM
F19802125: D21273.diff
Sun, Mar 1, 1:35 PM
F19792032: D21273.id.diff
Thu, Feb 26, 4:58 AM
F19785832: D21273.diff
Wed, Feb 25, 1:55 AM
F19785808: D21273.id50658.diff
Wed, Feb 25, 1:25 AM
F19664658: D21273.id.diff
Feb 7 2026, 12:19 PM
F19152650: D21273.diff
Dec 11 2025, 4:10 AM
F19012045: D21273.id.diff
Nov 22 2025, 11:49 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, all the inline code passes around strings to describe content. I plan to add background music, animation effects, etc., soon. To prepare for this change, make content a state object.

This does not change any user-visible behavior, it just prepares for content to become more complicated than a single string.

Test Plan

Created, edited, submitted, cancelled, etc., comments.

Diff Detail

Repository
rP Phabricator
Branch
inline7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24477
Build 33728: Run Core Tests
Build 33727: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:24 PM
This revision was automatically updated to reflect the committed changes.