Page MenuHomePhabricator

Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
ClosedPublic

Authored by epriestley on May 15 2020, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:44 AM
Unknown Object (File)
Mon, Apr 8, 7:49 AM
Unknown Object (File)
Sat, Apr 6, 11:31 PM
Unknown Object (File)
Sat, Apr 6, 9:33 AM
Unknown Object (File)
Wed, Apr 3, 12:13 PM
Unknown Object (File)
Feb 23 2024, 9:50 AM
Unknown Object (File)
Jan 24 2024, 2:46 PM
Unknown Object (File)
Jan 17 2024, 4:35 PM
Subscribers
None

Details

Summary

Ref T13513. See PHI1734, which raises a concern about the performance of large revisions near the 100-change threshold.

Currently, getInlines() is called whenever the scroll position transitions between two changesets, and it performs a relatively complicated DOM scan to lift inlines out of the document.

This shows up as taking a small but nontrivial amount of time in Firefox profiles and should be safely memoizable.

Test Plan
  • Under Firefox profiling, scrolled through a large revision.
  • Before change: getInlines() appeared as the highest-cost thing we're explicitly doing on profiles.
  • After change: getInlines() was no longer meaningfully represented on profiles.
  • Created inlines, edited inlines, etc. Didn't identify any broken behavior.

Diff Detail

Repository
rP Phabricator
Branch
perf1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24444
Build 33683: Run Core Tests
Build 33682: arc lint + arc unit