Page MenuHomePhabricator

Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact
ClosedPublic

Authored by epriestley on May 14 2020, 6:40 PM.
Tags
None
Referenced Files
F12841430: D21254.diff
Thu, Mar 28, 9:12 PM
Unknown Object (File)
Tue, Mar 5, 2:44 PM
Unknown Object (File)
Feb 16 2024, 4:32 AM
Unknown Object (File)
Feb 8 2024, 6:32 AM
Unknown Object (File)
Jan 19 2024, 4:42 PM
Unknown Object (File)
Jan 15 2024, 5:07 PM
Unknown Object (File)
Jan 12 2024, 9:21 AM
Unknown Object (File)
Jan 11 2024, 12:04 PM
Subscribers
None

Details

Summary

Ref T13513. In Safari, do this:

  • view a 2-up diff with content on both sides;
  • select more than one line on the right side; and
  • use your mouse to click "New Inline Comment" in the context menu that pops up.

The mousedown event for the "New Inline Comment" click removes the "copy selection" behavior and creates a flash where both sides of the diff are selected.

This doesn't happen with (most) normal clicks because mouse down on a non-grabbable element clears the document selection.

To avoid this, don't reset the copy selection behavior if the user mouses down on an "<a />". This might not be robust, but seems simple and plausible as a fix.

Test Plan
  • See above.
  • Before patch: flash of overbroad selection when clicking "New Inline Comment".
  • After patch: no selection flash.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable