When cancelling an inline comment edit, exit the edit state after the response arrives
ClosedPublic
Actions

Authored by epriestley on May 14 2020, 6:19 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPf45519c0604b: When cancelling an inline comment edit, exit the edit state after the response…

Summary

Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan

Clicked a line number.
Typed some text.
Clicked "Cancel".
Before patch: paths panel flashes "1".
After patch: paths panel stays stable.

Diff Detail

Repository

rP Phabricator

Branch

inline2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24426
Build 33657: Run Core Tests
Build 33656: arc lint + arc unit

Event Timeline

epriestley created this revision.May 14 2020, 6:19 PM

Harbormaster completed remote builds in B24426: Diff 50609.May 14 2020, 6:20 PM

epriestley requested review of this revision.May 14 2020, 6:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 9:28 PM

Closed by commit rPf45519c0604b: When cancelling an inline comment edit, exit the edit state after the response… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf45519c0604b: When cancelling an inline comment edit, exit the edit state after the response….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

3 lines

Diff 50609

View Options

resources/celerity/map.php