Page MenuHomePhabricator

When cancelling an inline comment edit, exit the edit state after the response arrives
ClosedPublic

Authored by epriestley on May 14 2020, 6:19 PM.
Tags
None
Referenced Files
F11541599: D21253.diff
Thu, Feb 9, 12:35 AM
Unknown Object (File)
Sat, Jan 21, 1:06 PM
Unknown Object (File)
Jan 5 2023, 4:50 AM
Unknown Object (File)
Dec 9 2022, 10:53 PM
Unknown Object (File)
Dec 9 2022, 10:53 PM
Unknown Object (File)
Dec 9 2022, 10:53 PM
Unknown Object (File)
Nov 27 2022, 10:41 PM
Unknown Object (File)
Nov 21 2022, 12:25 PM
Subscribers
None

Details

Summary

Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan
  • Clicked a line number.
  • Typed some text.
  • Clicked "Cancel".
  • Before patch: paths panel flashes "1".
  • After patch: paths panel stays stable.

Diff Detail

Repository
rP Phabricator
Branch
inline2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24426
Build 33657: Run Core Tests
Build 33656: arc lint + arc unit