Page MenuHomePhabricator

Improve select-to-comment behavior in Firefox and on unified diffs
ClosedPublic

Authored by epriestley on May 13 2020, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:55 PM
Unknown Object (File)
Mon, Jun 2, 12:11 PM
Unknown Object (File)
May 31 2025, 1:02 PM
Unknown Object (File)
May 10 2025, 1:22 AM
Unknown Object (File)
May 6 2025, 12:58 PM
Unknown Object (File)
Apr 30 2025, 1:09 PM
Unknown Object (File)
Apr 30 2025, 12:46 PM
Unknown Object (File)
Apr 2 2025, 11:36 PM
Subscribers
None

Details

Summary

Ref T13513.

  • Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
  • Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.
Test Plan
  • Selected multiple lines of content in Firefox, got an option to add a comment.
  • Selected content in unified mode, got an option to add a comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:19 AM
This revision was automatically updated to reflect the committed changes.