Page MenuHomePhabricator

Improve select-to-comment behavior in Firefox and on unified diffs
ClosedPublic

Authored by epriestley on May 13 2020, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 11:38 PM
Unknown Object (File)
Jan 16 2024, 5:08 AM
Unknown Object (File)
Dec 20 2023, 10:41 AM
Unknown Object (File)
Dec 15 2023, 7:53 AM
Unknown Object (File)
Dec 12 2023, 4:46 AM
Unknown Object (File)
Nov 29 2023, 11:36 PM
Unknown Object (File)
Nov 25 2023, 11:31 PM
Unknown Object (File)
Nov 15 2023, 1:32 AM
Subscribers
None

Details

Summary

Ref T13513.

  • Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
  • Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.
Test Plan
  • Selected multiple lines of content in Firefox, got an option to add a comment.
  • Selected content in unified mode, got an option to add a comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:19 AM
This revision was automatically updated to reflect the committed changes.