Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F18790972: D21236.id50574.diff
Wed, Oct 15, 9:55 PM
F18769288: D21236.id50572.diff
Wed, Oct 8, 7:04 AM
F18729517: D21236.id50574.diff
Tue, Sep 30, 11:16 AM
F18636430: D21236.diff
Sep 17 2025, 4:18 AM
F18409080: D21236.diff
Aug 30 2025, 3:37 AM
F18112328: D21236.diff
Aug 12 2025, 4:24 PM
F18101104: D21236.id.diff
Aug 9 2025, 12:19 PM
F18081198: D21236.id.diff
Aug 4 2025, 10:56 PM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.