Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F18112328: D21236.diff
Tue, Aug 12, 4:24 PM
F18101104: D21236.id.diff
Sat, Aug 9, 12:19 PM
F18081198: D21236.id.diff
Mon, Aug 4, 10:56 PM
F18050822: D21236.diff
Sun, Aug 3, 9:09 PM
F17867674: D21236.id50574.diff
Jul 28 2025, 6:31 AM
F17861013: D21236.id.diff
Jul 27 2025, 10:27 PM
F17855707: D21236.id50572.diff
Jul 27 2025, 4:30 PM
F17855229: D21236.diff
Jul 27 2025, 4:03 PM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.