Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on Fri, May 8, 1:39 PM.

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 8, 1:39 PM
epriestley requested review of this revision.Fri, May 8, 1:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 8, 1:59 PM
This revision was automatically updated to reflect the committed changes.