Page MenuHomePhabricator

Persist "Show Changeset" and improve path text selection
ClosedPublic

Authored by epriestley on May 8 2020, 1:39 PM.
Tags
None
Referenced Files
F19511377: D21236.id50572.diff
Mon, Jan 12, 1:27 AM
F19505137: D21236.diff
Fri, Jan 9, 9:30 AM
F19043334: D21236.id.diff
Nov 26 2025, 9:37 PM
F18906504: D21236.diff
Nov 8 2025, 6:47 PM
F18790972: D21236.id50574.diff
Oct 15 2025, 9:55 PM
F18769288: D21236.id50572.diff
Oct 8 2025, 7:04 AM
F18729517: D21236.id50574.diff
Sep 30 2025, 11:16 AM
F18636430: D21236.diff
Sep 17 2025, 4:18 AM
Subscribers
None

Details

Summary

Ref T13513. Currently:

  • If you click the "Show Changeset" button, your state change doesn't actually get saved on the server.
  • It's hard to select a changeset path name for copy/paste because the "highlight the header" code tends to eat the event.

Instead: persist the former event; make the actual path text not be part of the highlight hitbox.

Test Plan
  • Clicked "Show Changeset", reloaded, saw changeset visibility persisted.
  • Selected changeset path text without issues.
  • Clicked non-text header area to select/deselect changesets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.