Page MenuHomePhabricator
Differential D21226

Allow inline comment storage objects to generate their own runtime objects
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 3:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:07 PM
Unknown Object (File)
Wed, Apr 17, 3:09 PM
Unknown Object (File)
Wed, Apr 17, 10:59 AM
Unknown Object (File)
Thu, Apr 11, 7:18 AM
Unknown Object (File)
Mar 24 2024, 10:56 AM
Unknown Object (File)
Feb 21 2024, 5:15 AM
Unknown Object (File)
Feb 9 2024, 12:10 AM
Unknown Object (File)
Jan 15 2024, 8:01 PM
View All 55 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP1656a2ff081a: Allow inline comment storage objects to generate their own runtime objects
Summary

Ref T13513. Currently, inline storage objects ("TransactionComment") can't directly generate a runtime object ("InlineComment").

Allow this transformation to be performed in a genric way so clunky code which does it per-object-type can be removed, lifted, or simplified.

Simplify an especially gross callsite in preview code.

Test Plan

Previewed inline comments.

Diff Detail

Repository
rP Phabricator
Branch
iquery3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24367
Build 33569: Run Core Tests
Build 33568: arc lint + arc unit

Event Timeline

epriestley created this revision.May 7 2020, 3:50 PM
Harbormaster completed remote builds in B24367: Diff 50551.May 7 2020, 3:52 PM
epriestley requested review of this revision.May 7 2020, 3:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 10:57 PM
Closed by commit rP1656a2ff081a: Allow inline comment storage objects to generate their own runtime objects (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP1656a2ff081a: Allow inline comment storage objects to generate their own runtime objects.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
audit/
storage/
8 lines
differential/
storage/
8 lines
transactions/
interface/
7 lines
infrastructure/
diff/
view/
10 lines
webroot/
rsrc/
js/
application/
repository/
2 lines

Diff 50551

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...
View Options

src/applications/transactions/interface/PhabricatorInlineCommentInterface.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

Loading...
View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...
Phabricator · Built by Phacility