Page MenuHomePhabricator

Allow inline comment storage objects to generate their own runtime objects

Authored by epriestley on Thu, May 7, 3:50 PM.



Ref T13513. Currently, inline storage objects ("TransactionComment") can't directly generate a runtime object ("InlineComment").

Allow this transformation to be performed in a genric way so clunky code which does it per-object-type can be removed, lifted, or simplified.

Simplify an especially gross callsite in preview code.

Test Plan

Previewed inline comments.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 7, 3:50 PM
epriestley requested review of this revision.Thu, May 7, 3:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 7, 10:57 PM
This revision was automatically updated to reflect the committed changes.