Page MenuHomePhabricator
Differential D21226

Allow inline comment storage objects to generate their own runtime objects
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 3:50 PM.
Tags
None
Referenced Files
F19049176: D21226.id.diff
Thu, Nov 27, 4:28 PM
F19015117: D21226.id50562.diff
Sat, Nov 22, 11:13 PM
F19010631: D21226.diff
Sat, Nov 22, 5:54 AM
F18816523: D21226.diff
Oct 21 2025, 7:28 AM
F18814898: D21226.id.diff
Oct 21 2025, 12:05 AM
F18810936: D21226.id50551.diff
Oct 20 2025, 12:09 AM
F18808231: D21226.diff
Oct 19 2025, 5:38 AM
F18807421: D21226.id50562.diff
Oct 19 2025, 1:34 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP1656a2ff081a: Allow inline comment storage objects to generate their own runtime objects
Summary

Ref T13513. Currently, inline storage objects ("TransactionComment") can't directly generate a runtime object ("InlineComment").

Allow this transformation to be performed in a genric way so clunky code which does it per-object-type can be removed, lifted, or simplified.

Simplify an especially gross callsite in preview code.

Test Plan

Previewed inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 7 2020, 3:50 PM
Harbormaster completed remote builds in B24367: Diff 50551.May 7 2020, 3:52 PM
epriestley requested review of this revision.May 7 2020, 3:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 10:57 PM
Closed by commit rP1656a2ff081a: Allow inline comment storage objects to generate their own runtime objects (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP1656a2ff081a: Allow inline comment storage objects to generate their own runtime objects.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
audit/
storage/
8 lines
differential/
storage/
8 lines
transactions/
interface/
7 lines
infrastructure/
diff/
view/
10 lines
webroot/
rsrc/
js/
application/
repository/
2 lines

Diff 50562

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...
View Options

src/applications/transactions/interface/PhabricatorInlineCommentInterface.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

Loading...
View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...
Phabricator · Built by Phacility