Page MenuHomePhabricator

Fix an initialization issue in VectorTree
ClosedPublic

Authored by epriestley on Mon, May 4, 10:48 PM.

Details

Summary

Ref T13520. In unusual cases where there are no changes in a changeset list (e.g., empty commits) we can fatal when trying to iterate over an empty list of vectors.

Test Plan
  • Created an empty commit.
  • Used "git show | pbcopy" to create a diff from it.
  • Viewed it in the web UI.
  • Before: fatal when iterating on null.
  • After: clean page.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 10:48 PM
epriestley requested review of this revision.Mon, May 4, 10:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 10:50 PM
This revision was automatically updated to reflect the committed changes.