Page MenuHomePhabricator

Refine unusual inline comment client interactions
ClosedPublic

Authored by epriestley on Mon, May 4, 4:33 PM.

Details

Summary

Ref T13513. Refine some inline behaviors, see test plan.

Test Plan
  • Edit a comment ("A"), type text ("AB"), cancel, edit.
    • Old behavior: edit and undo states (wrong, and undo does not function).
    • New behavior: edit state only.
  • Edit a comment ("A"), type text ("AB"), cancel. Undo ("AB"), cancel. Edit.
    • Old behavior: "AB" (wrong: you never submitted this text).
    • New behavior: "A".
  • Create a comment, type text, cancel.
    • Old behavior: counter appears in filetree (wrong, comment is undo-able but should not be counted).
    • New behavior: no counter.
  • Cancel editing an empty comment with no text.
    • Old behavior: Something buggy -- undo, I think?
    • New behavior: it just vanishes (correct behavior).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 4:33 PM
epriestley requested review of this revision.Mon, May 4, 4:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 8:15 PM
This revision was automatically updated to reflect the committed changes.