Page MenuHomePhabricator

Refine unusual inline comment client interactions
ClosedPublic

Authored by epriestley on May 4 2020, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 3:56 PM
Unknown Object (File)
Thu, Jan 2, 2:49 PM
Unknown Object (File)
Thu, Jan 2, 2:49 PM
Unknown Object (File)
Thu, Jan 2, 12:04 PM
Unknown Object (File)
Mon, Dec 30, 5:59 AM
Unknown Object (File)
Mon, Dec 16, 8:26 AM
Unknown Object (File)
Fri, Dec 13, 2:11 PM
Unknown Object (File)
Dec 11 2024, 8:19 AM
Subscribers
None

Details

Summary

Ref T13513. Refine some inline behaviors, see test plan.

Test Plan
  • Edit a comment ("A"), type text ("AB"), cancel, edit.
    • Old behavior: edit and undo states (wrong, and undo does not function).
    • New behavior: edit state only.
  • Edit a comment ("A"), type text ("AB"), cancel. Undo ("AB"), cancel. Edit.
    • Old behavior: "AB" (wrong: you never submitted this text).
    • New behavior: "A".
  • Create a comment, type text, cancel.
    • Old behavior: counter appears in filetree (wrong, comment is undo-able but should not be counted).
    • New behavior: no counter.
  • Cancel editing an empty comment with no text.
    • Old behavior: Something buggy -- undo, I think?
    • New behavior: it just vanishes (correct behavior).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:15 PM
This revision was automatically updated to reflect the committed changes.