Ref T13513. Refine some inline behaviors, see test plan.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13513: Make schema changes to inlines to prepare for new inline features
- Commits
- rP63bfad0ff476: Refine unusual inline comment client interactions
- Edit a comment ("A"), type text ("AB"), cancel, edit.
- Old behavior: edit and undo states (wrong, and undo does not function).
- New behavior: edit state only.
- Edit a comment ("A"), type text ("AB"), cancel. Undo ("AB"), cancel. Edit.
- Old behavior: "AB" (wrong: you never submitted this text).
- New behavior: "A".
- Create a comment, type text, cancel.
- Old behavior: counter appears in filetree (wrong, comment is undo-able but should not be counted).
- New behavior: no counter.
- Cancel editing an empty comment with no text.
- Old behavior: Something buggy -- undo, I think?
- New behavior: it just vanishes (correct behavior).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- inline7
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 24331 Build 33519: Run Core Tests Build 33518: arc lint + arc unit