Page MenuHomePhabricator

Refine unusual inline comment client interactions
ClosedPublic

Authored by epriestley on May 4 2020, 4:33 PM.
Tags
None
Referenced Files
F15490712: D21212.diff
Fri, Apr 11, 7:55 PM
F15479123: D21212.diff
Tue, Apr 8, 5:10 AM
F15479104: D21212.id.diff
Tue, Apr 8, 5:09 AM
F15479068: D21212.id50526.diff
Tue, Apr 8, 5:07 AM
F15479062: D21212.id50514.diff
Tue, Apr 8, 5:07 AM
F15468069: D21212.diff
Thu, Apr 3, 8:04 PM
F15456445: D21212.diff
Sun, Mar 30, 9:45 AM
F15439388: D21212.id50514.diff
Wed, Mar 26, 7:19 AM
Subscribers
None

Details

Summary

Ref T13513. Refine some inline behaviors, see test plan.

Test Plan
  • Edit a comment ("A"), type text ("AB"), cancel, edit.
    • Old behavior: edit and undo states (wrong, and undo does not function).
    • New behavior: edit state only.
  • Edit a comment ("A"), type text ("AB"), cancel. Undo ("AB"), cancel. Edit.
    • Old behavior: "AB" (wrong: you never submitted this text).
    • New behavior: "A".
  • Create a comment, type text, cancel.
    • Old behavior: counter appears in filetree (wrong, comment is undo-able but should not be counted).
    • New behavior: no counter.
  • Cancel editing an empty comment with no text.
    • Old behavior: Something buggy -- undo, I think?
    • New behavior: it just vanishes (correct behavior).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:15 PM
This revision was automatically updated to reflect the committed changes.