Page MenuHomePhabricator

Route hard-coded "/favicon.ico" requests to a favicon resource
ClosedPublic

Authored by epriestley on May 1 2020, 12:16 PM.
Tags
None
Referenced Files
F16804083: D21195.id.diff
Wed, Jun 18, 5:02 AM
F16729277: D21195.diff
Tue, Jun 17, 7:22 PM
Unknown Object (File)
Tue, May 27, 4:43 AM
Unknown Object (File)
May 7 2025, 10:23 PM
Unknown Object (File)
May 6 2025, 6:25 AM
Unknown Object (File)
Apr 22 2025, 3:53 AM
Unknown Object (File)
Apr 1 2025, 12:58 AM
Unknown Object (File)
Mar 31 2025, 2:47 PM
Subscribers
None

Details

Summary

See PHI1719. User agents making hard-coded requests to "/favicon.ico" currently 404. This is a mild source of log noise, and we can reasonably route this request.

Limitations:

  • This only routes the "PlatformSite". Other sites (custom Phame blogs, third-party sites, Phurl redirectors) won't route here for now.
  • This returns a "Location:" redirect to the correct resource rather than icon data directly. This produces the right icon with the right caching behavior, and returning icon data directly is difficult in the general case. However, it won't perform/cache as well as a direct response would.
Test Plan
  • Visted /favicon.ico.
  • Before: 404.
  • After: redirect to favicon.

Diff Detail

Repository
rP Phabricator
Branch
favicon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24293
Build 33464: Run Core Tests
Build 33463: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 12:23 PM
This revision was automatically updated to reflect the committed changes.