Fixes T13527. Some versions of PHP strictly require that we pass a string value, and reject "stringlike" objects (objects which implement "__toString()").
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13527: "mb_check_encoding()" may rase a warning if passed an object which implements "__toString()"
- Commits
- rARCc1d12ff7784b: (stable) Work around "mb_check_encoding(<stringlike-object>)" warning in…
rARC696ec3f97585: Work around "mb_check_encoding(<stringlike-object>)" warning in particular…
Ran unit test, although this is somewhat aspirational because my local PHP version isn't affected.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- utf81
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 24287 Build 33456: Run Core Tests Build 33455: arc lint + arc unit