Differential D21192

Restore the ":(attr:filter=lfs)" test for LFS
ClosedPublic
Actions

Authored by epriestley on Apr 30 2020, 4:01 AM.

Tags

None

Referenced Files

	F18744729: D21192.id50469.diff
	Fri, Oct 3, 3:58 AM

	F18734276: D21192.id.diff
	Tue, Sep 30, 10:51 PM

	F18726771: D21192.id.diff
	Tue, Sep 30, 7:12 AM

	F18721348: D21192.diff
	Mon, Sep 29, 8:57 PM

	F18717859: D21192.id50470.diff
	Mon, Sep 29, 2:34 PM

	F18655294: D21192.diff
	Mon, Sep 22, 7:38 PM

	F18646860: D21192.id.diff
	Fri, Sep 19, 11:19 AM

	F18622152: D21192.diff
	Sep 15 2025, 10:37 AM

Subscribers

Details

Reviewers: None
Commits: rARCce7bd679804c: (stable) Restore the ":(attr:filter=lfs)" test for LFS
rARC284139a24ea4: Restore the ":(attr:filter=lfs)" test for LFS

Summary

See D21190. The ".gitattributes" approach fails when ".gitattributes" is in a subdirectory (or global). These are probably unusual cases, but at least one is known in the wild.

Instead:

Restore the ":(attr:filter=lfs)" test, which seems to be the fastest accurate test available in modern Git.
If the test fails, assume the repository is not LFS. This only impacts users running very old versions of Git.

Test Plan

In LFS and non-LFS repositories, created diffs. Saw correct detection again.
Broke the command on purpose, saw LFS detection conclude "no LFS", but not fail disastrously.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 30 2020, 4:01 AM

Harbormaster completed remote builds in B24284: Diff 50469.Apr 30 2020, 4:01 AM

epriestley requested review of this revision.Apr 30 2020, 4:01 AM

epriestley mentioned this in D21190: Detect LFS by looking for tracks in ".gitattributes" instead of using "ls-tree".Apr 30 2020, 4:03 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2020, 4:04 AM

Closed by commit rARC284139a24ea4: Restore the ":(attr:filter=lfs)" test for LFS (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC284139a24ea4: Restore the ":(attr:filter=lfs)" test for LFS.

epriestley added a commit: rARCce7bd679804c: (stable) Restore the ":(attr:filter=lfs)" test for LFS.

Thanks so much for fixing this!

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

63 lines

Diff 50470

src/repository/api/ArcanistGitAPI.php

Loading...