Page MenuHomePhabricator

Replace "PhutilFileTree" with a more abstract "VectorTree"
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:06 PM.
Tags
None
Referenced Files
F13083374: D21182.diff
Wed, Apr 24, 10:31 PM
F13081129: D21182.id50444.diff
Wed, Apr 24, 2:53 PM
Unknown Object (File)
Sun, Apr 21, 10:23 PM
Unknown Object (File)
Mon, Apr 8, 11:43 AM
Unknown Object (File)
Sun, Apr 7, 3:43 PM
Unknown Object (File)
Sun, Mar 31, 12:45 AM
Unknown Object (File)
Fri, Mar 29, 10:45 AM
Unknown Object (File)
Thu, Mar 28, 8:52 PM
Subscribers
None

Details

Summary

Ref T13520. Replace "FileTree" with a "VectorTree" that does roughly the same thing. The major goals are:

  • Compress trees which contain sequences of child directories with no sibilings.
  • Build hierarchies of paths where path components may include renames.

This is approximately similar to "FileTree" and similar to client logic in the new paths panel.

Test Plan

See next change.

Diff Detail

Repository
rARC Arcanist
Branch
node1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24262
Build 33417: Run Core Tests
Build 33416: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:10 PM
This revision was automatically updated to reflect the committed changes.