Page MenuHomePhabricator
Differential D21179

Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"
ClosedPublic
Actions

Authored by epriestley on Apr 28 2020, 10:56 AM.
Tags
None
Referenced Files
F13131267: D21179.diff
Wed, May 1, 3:24 PM
Unknown Object (File)
Thu, Apr 25, 2:20 AM
Unknown Object (File)
Mar 31 2024, 11:34 AM
Unknown Object (File)
Feb 20 2024, 7:36 AM
Unknown Object (File)
Feb 13 2024, 11:41 AM
Unknown Object (File)
Feb 11 2024, 10:27 AM
Unknown Object (File)
Jan 15 2024, 10:15 PM
Unknown Object (File)
Dec 28 2023, 2:05 AM
View All 58 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13525: "apcu_store()" may raise "GC cache entry ..." errors
Commits
rPa338b1f43308: (stable) Use "@" to silence "GC list" warnings from "apc_store()" and…
rP5eaa0f24e7b7: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"
Summary

Fixes T13525. Since D21044, the intermittent GC list warnings are treated more severely and can become user-visible errors.

Silence them, since this seems to be the only realistic response in most versions of APC/APCu.

Test Plan

Will deploy.

Diff Detail

Event Timeline

epriestley created this revision.Apr 28 2020, 10:56 AM
Harbormaster completed remote builds in B24254: Diff 50435.Apr 28 2020, 10:57 AM
epriestley requested review of this revision.Apr 28 2020, 10:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 11:13 AM
This revision was landed with ongoing or failed builds.
Closed by commit rP5eaa0f24e7b7: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5eaa0f24e7b7: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()".
epriestley added a commit: rPa338b1f43308: (stable) Use "@" to silence "GC list" warnings from "apc_store()" and….

Revision Contents
Changeset List

PathSize
src/
infrastructure/
cache/
7 lines
support/
startup/
12 lines

Diff 50435

View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php

Loading...
View Options

support/startup/PhabricatorClientLimit.php

Loading...
Phabricator · Built by Phacility