Page MenuHomePhabricator
Differential D21162

Don't show the "file tree" view on tablets/phones
ClosedPublic
Actions

Authored by epriestley on Apr 23 2020, 8:17 PM.
Tags
None
Referenced Files
F14110054: D21162.diff
Wed, Nov 27, 4:16 PM
F14107205: D21162.id50384.diff
Wed, Nov 27, 7:31 AM
Unknown Object (File)
Mon, Nov 25, 3:28 AM
Unknown Object (File)
Sun, Nov 24, 12:53 AM
Unknown Object (File)
Wed, Nov 20, 3:18 AM
Unknown Object (File)
Sat, Nov 16, 4:44 AM
Unknown Object (File)
Tue, Nov 12, 11:37 AM
Unknown Object (File)
Sat, Nov 9, 7:01 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits
rP4793bfcb7c49: Don't show the "file tree" view on tablets/phones
Summary

Ref T13516. Hide this UI on devices without the screen width to reasonably support it.

Test Plan

Viewed a revision at various window widths, saw the elements vanish at device widths and reappear at desktop widths.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 23 2020, 8:17 PM
Harbormaster completed remote builds in B24202: Diff 50384.Apr 23 2020, 8:19 PM
epriestley requested review of this revision.Apr 23 2020, 8:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2020, 8:40 PM
Closed by commit rP4793bfcb7c49: Don't show the "file tree" view on tablets/phones (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP4793bfcb7c49: Don't show the "file tree" view on tablets/phones.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
engine/
1 line
view/
formation/
10 lines
10 lines
webroot/
rsrc/
css/
phui/
20 lines

Diff 50386

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/engine/DifferentialFileTreeEngine.php

Loading...
View Options

src/view/formation/PHUIFormationColumnView.php

Loading...
View Options

src/view/formation/PHUIFormationView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-formation-view.css

Loading...
Phabricator · Built by Phacility